Change Snippet in transactedinstaller.cs #3997
Merged
+8
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
|
I'm waiting to review this, as I think it may have been fixed by the work @Thraka did in recovering a number of snipppets. |
Thraka
added
the
✨ 1st-time dotnet-api-docs contributor!
|
@BillWagner The change @Asugakoisi is proposing actually just exposes more of the code, the entire sample (namespace declarations, the logging method, etc), which isn't many more lines. to what is published currently. @Asugakoisi Is there somewhere you saw the snippet#2 being used? I can't find it anywhere. I think that |
|
I'm sorry for forgetting checking these comments. I removed |
Thraka
approved these changes
Mar 20, 2020
|
Thanks @Asugakoisi !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I changed snippet in transactedinstaller.cs
because I can't see all sample code in https://docs.microsoft.com/en-us/dotnet/api/system.configuration.install.transactedinstaller?view=netframework-4.8
Fixes #Issue_Number (if available)